Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir.1.14 #422

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Elixir.1.14 #422

merged 2 commits into from
Sep 13, 2023

Conversation

Sinc63
Copy link
Collaborator

@Sinc63 Sinc63 commented Sep 11, 2023

There are two updates here.

The first resolves a number of issues related to Elixir 1.14 and an upgrade of ex_doc. It changes the use of "use Bitwise" and eliminates the use of get_env at compile time. It eliminates the use of "use Mix.Config", anticipates the deprecation of Logger.warn in 1.15, and fixes some problems running test and mix docs. (I still can't run tests because it doesn't like me running "MIX_ENV=test mix ecto.create", but at least the compile warnings are resolved.)

The second update resolves dialyxir warnings from two sources. I ran it against the project itself and tried to resolve those errors including resolving some suppressed errors, but I also ran it against InfinityOne where I know it generates a lot of warnings of a repetitive type. The latter effort triggered the mass of changes in the responders, where the arity 1 functions inserting an empty map generally didn't help, because the arity two functions almost all require some specific keys in the map, so will fail with a FunctionClauseError, where now if you call the arity 1 it should fail on compile.

I suggest reviewing the two commits independently.

@Sinc63
Copy link
Collaborator Author

Sinc63 commented Sep 11, 2023

This PR includes most of the content of #420 #416 and #393, which I will mark appropriately once this is merged.

@smpallen99
Copy link
Owner

Appoved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants