AFD failure now sources underlying I/O error #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if AFD failed to initialize `polling` would return a custom I/O error with a string error, containing the formatted version of the underlying system error. However, this means that information about the underlying system error is lost to the user. This commit makes it so the returned `io::Error` wraps a user inaccessible type: `AfdError`. This `AfdError`, when stringified, returns a similar error message as what was previously returned. In addition when `.source()` is used it returns the underlying system error. Closes #174 Signed-off-by: John Nunley <dev@notgull.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if AFD failed to initialize
pollingwould return a customI/O error with a string error, containing the formatted version of the
underlying system error. However, this means that information about the
underlying system error is lost to the user.
This commit makes it so the returned
io::Errorwraps a userinaccessible type:
AfdError. ThisAfdError, when stringified,returns a similar error message as what was previously returned. In
addition when
.source()is used it returns the underlying systemerror.
Closes #174