Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tagged notifications #52

Merged
merged 9 commits into from
May 13, 2023
Merged

feat: Add tagged notifications #52

merged 9 commits into from
May 13, 2023

Commits on Apr 3, 2023

  1. Add the Notification trait 

    This will be used to replace the notify_* family of functions.
    @notgull
    notgull committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    d986a5c View commit details
    Browse the repository at this point in the history

  2. Adjust the Notification logic slightly 

    I missed that this is needed for notification propogation.
    @notgull
    notgull committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    5f67dd0 View commit details
    Browse the repository at this point in the history

  3. Change out SingleNotify for GenericNotify

    @notgull
    notgull committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    266b60d View commit details
    Browse the repository at this point in the history

  4. Add a type parameter T to Event 

    Sets up tagged events to use the Notification trait.
    @notgull
    notgull committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    e001c7a View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Fix various CI errors 

    Fixes the following issues:

- Failed to build on MSRV due to Unpin bound
- Failed to build on no_std, as I didn't import Box
- Failed to build on portable-atomic, as Arc didn't implement Unpin
    @notgull
    notgull committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    723c328 View commit details
    Browse the repository at this point in the history

  2. Seal the Notification and IntoNotification traits 

    This PR seals these two traits to prevent breaking changes from causing
semver breaks. It also adds documentation to both traits.
    @notgull
    notgull committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    15b4ea2 View commit details
    Browse the repository at this point in the history

  3. Fix doctests

    @notgull
    notgull committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a7e74b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Wire up the Strategy trait with the new tags

    @notgull
    notgull committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a8c3aa7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Replace boxed closure with a vec of tags 

    This should hopefully reduce the amount of allocation on the cold no_std
path
    @notgull
    notgull committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9275054 View commit details
    Browse the repository at this point in the history