Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackSlot should be send #119

Merged
merged 1 commit into from
Feb 10, 2024
Merged

StackSlot should be send #119

merged 1 commit into from
Feb 10, 2024

Conversation

mattklein123
Copy link

Fixes #118

@mattklein123
Copy link
Author

IMO it would be good to add a test that uses tokio and actually exercises this for real in that context. I can add one if you like.

@mattklein123
StackSlot should be send
105f3c5 
Signed-off-by: Matt Klein <mklein@bitdrift.io>
notgull
notgull approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

IMO it would be good to add a test that uses tokio and actually exercises this for real in that context. I can add one if you like.

Yes, that would be appreciated. Feel free to do it in another PR.

@notgull notgull merged commit e5464b4 into smol-rs:master Feb 10, 2024
9 checks passed
@notgull notgull mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about new API
2 participants
@mattklein123 @notgull