add method total_listeners() when feature std #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
Jan 16, 2024
There was a problem hiding this comment.
I think the documentation should be modified with less guarantees as to the effectiveness of this function. For instance, the documentation should mention all of the following:
- This is just a snapshot of the number of listeners at this point in time. It is possible for the actual number to change at any point.
- The number should only ever be used as a hint.
|
@notgull could you review it again? |
notgull
requested changes
Jan 21, 2024
| @@ -54,6 +54,14 @@ impl<T> List<T> { | |||
| Err(_) => Err("<locked>"), | |||
| } | |||
| } | |||
|
|
|||
| // Get the listener count by blocking | |||
| pub(crate) fn total_listeners_wait(&self) -> usize { | |||
There was a problem hiding this comment.
Name this function total_listeners instead.
There was a problem hiding this comment.
total_listeners is already defined just above.
Merged
notgull
added a commit
that referenced
this pull request
Apr 14, 2024
Mirror of #114 Signed-off-by: John Nunley <dev@notgull.net>
notgull
added a commit
that referenced
this pull request
Apr 16, 2024
Mirror of #114 Signed-off-by: John Nunley <dev@notgull.net>
notgull
added a commit
that referenced
this pull request
Apr 18, 2024
Mirror of #114 Signed-off-by: John Nunley <dev@notgull.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#106