Make the raw task layout const #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be failing CI due to an API that was unstable when const panics was stabilized. It compiles fine locally on my 1.61 environment. I don't know if bumping the MSRV past 1.57 is a good idea: it's already pretty recent. Any opinion on this? I can just revert |
|
There are currently no plans to drop support for Rust 1.48 used by Debian stable. |
|
If that's the case, would writing out a |
This reverts commit bbfa0b8.
|
Sounds good to me. |
|
It does seem like a lot of these const methods are available, even in 1.48. I'll close this out for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few points that aren't 100% const in the std/core lib, but it's possible to compute the task layout at compile time to avoid the overhead of computing it for the task on every vtable call.