Instrument with loom #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully allow us to get to the bottom of these deadlocks. Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
This was referenced May 26, 2024
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
I think this bug is new Signed-off-by: John Nunley <dev@notgull.net>
taiki-e
reviewed
Jun 1, 2024
|
|
||
| use async_lock::Barrier; | ||
|
|
||
| #[ignore] |
There was a problem hiding this comment.
This PR doesn't seem to add any tests that are actually run in CI.
|
|
||
| [features] | ||
| default = ["std"] | ||
| portable-atomic = ["portable-atomic-util", "portable_atomic_crate"] |
There was a problem hiding this comment.
I saw the changes to lib.rs, but this doesn't really seem to be in use?
There was a problem hiding this comment.
Whoops, I was going to add a portable-atomic impl but forgot to. Will fix this.
notgull
added a commit
that referenced
this pull request
Jun 1, 2024
I added half of a portable-atomic implementation in #86 and forgot to finish it. This removes it prior to release. Signed-off-by: John Nunley <dev@notgull.net>
notgull
added a commit
that referenced
this pull request
Jun 1, 2024
I added half of a portable-atomic implementation in #86 and forgot to finish it. This removes it prior to release. Signed-off-by: John Nunley <dev@notgull.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds loom instrumentation to help find bugs