Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Arc blocking methods #71

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

Jules-Bertholet
Copy link
Collaborator

Adds:

  • Rwlock::read_arc_blocking
  • RwLock::upgradable_read_arc_blocking
  • RwLock::write_arc_blocking
  • RwLockUpgradableReadGuardArc::upgrade_blocking
  • Semaphore::acquire_arc_blocking

Adds:

- `Rwlock::read_arc_blocking`
- `RwLock::upgradable_read_arc_blocking`
- `RwLock::write_arc_blocking`
- `RwLockUpgradableReadGuardArc::upgrade_blocking`
- `Semaphore::acquire_arc_blocking`
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for these new methods?

@Jules-Bertholet Jules-Bertholet merged commit d1cff63 into smol-rs:master Nov 26, 2023
9 checks passed
@Jules-Bertholet Jules-Bertholet deleted the arc-blocking branch November 26, 2023 03:19
@notgull notgull mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants