Support for the ESP-IDF framework #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
Aug 6, 2023
ivmarkov
force-pushed
the
espidf
branch
2 times, most recently
from
87a7bf5
to
d34d1da
Compare
taiki-e
reviewed
Aug 6, 2023
Comment on lines
+48
to
+51
| # - name: Check selected Tier 3 targets | ||
| # if: startsWith(matrix.rust, 'nightly') && matrix.os == 'ubuntu-latest' | ||
| # run: cargo check -Z build-std --target=riscv32imc-esp-espidf |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
See this: #144 (comment)
There was a problem hiding this comment.
Ah, thanks for the explanation. Could you add a todo comment with the explanation on it or a link to your comment?
I did, but for now the actual
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TimerOpstruct size - depending on the platform - is anything between 20 to 28 bytes (if not more due to alignment). When multiplied by 1000 timers for the bounded queue we get into 20K to 30K RAM usage.Minuscule amount for regular machines or even for embedded-Linux SOCs, but quite a lot for MCUs which have 200 to 400K RAM.
Reducing the queue to 100 timers seems reasonable to me, because I don't expect hundreds of timers to be used on that platform.