Add csv output format to validate command #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
approved these changes
Feb 8, 2024
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/ValidationEventFormatOptions.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/ValidationEventFormatOptions.java
Outdated
Show resolved
Hide resolved
hpmellema
reviewed
Feb 8, 2024
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/ValidationEventFormatOptions.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/ValidationEventFormatOptions.java
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/ValidationEventFormatOptions.java
Outdated
Show resolved
Hide resolved
You can now pass `--format text|csv` to the validate and diff commands to get CSV or text output. Text continues to be the default when not specified. This commit also updates the diff command to now correctly output events to stdout rather than stderr.
mtdowling
force-pushed
the
add-csv-output-to-validate-command
branch
from
5992fb8
to
4139b3e
Compare
hpmellema
approved these changes
Feb 12, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now pass
--validation-format text|csvto the validate command to get CSV or text output. Text continues to be the default when not specified.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.