Updated SpectraFileInfo, changed fields to properties #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
=======================================
Coverage 75.47% 75.48%
=======================================
Files 201 201
Lines 30851 30857 +6
Branches 3112 3112
=======================================
+ Hits 23286 23292 +6
Misses 7039 7039
Partials 526 526
|
nbollis
approved these changes
Aug 20, 2024
trishorts
approved these changes
Aug 23, 2024
zhuoxinshi
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FlashLFQ GUI is going to be refactored to use the new ExternalResults classes in readers when reading in search results. This change is upstream of that.