-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Johnny Deconv 1st Step #791
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 75.46% 75.34% -0.12%
==========================================
Files 201 203 +2
Lines 30814 30859 +45
Branches 3106 3111 +5
==========================================
- Hits 23254 23251 -3
- Misses 7035 7082 +47
- Partials 525 526 +1
|
maybe we can add something for each new decon method about which of the two camps it falls into. |
…testing environment
[StructLayout(LayoutKind.Sequential, Pack =1)] | ||
public struct MatchedPeak | ||
{ | ||
public float mz; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to use our standard variable names for these features.
foreach(MatchedPeak peak in matchedpeaks) | ||
{ | ||
List<(double,double)> peaks = new List<(double,double)> (); | ||
List<double> listofratios = new List<double>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better variable name
…y correct charge states
…ect charge at least.
What mass range and resolution will this method apply to? |
Added the boilerplate for John to go in and add his dlll