Johnny Deconv 1st Step #791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 75.46% 75.34% -0.12%
==========================================
Files 201 203 +2
Lines 30814 30859 +45
Branches 3106 3111 +5
==========================================
- Hits 23254 23251 -3
- Misses 7035 7082 +47
- Partials 525 526 +1
|
|
maybe we can add something for each new decon method about which of the two camps it falls into. |
…testing environment
trishorts
reviewed
Aug 6, 2024
| [StructLayout(LayoutKind.Sequential, Pack =1)] | ||
| public struct MatchedPeak | ||
| { | ||
| public float mz; |
There was a problem hiding this comment.
would be good to use our standard variable names for these features.
trishorts
reviewed
Aug 6, 2024
| foreach(MatchedPeak peak in matchedpeaks) | ||
| { | ||
| List<(double,double)> peaks = new List<(double,double)> (); | ||
| List<double> listofratios = new List<double>(); |
added 2 commits
August 6, 2024 08:59
…y correct charge states
…ect charge at least.
|
What mass range and resolution will this method apply to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the boilerplate for John to go in and add his dlll