-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blade stiffened shell improvements #319
base: master
Are you sure you want to change the base?
Conversation
…edShellConstitutive`
… match other failure modes
@sean-engelstad, could you review this PR when you get a chance and see if these new methods can be utilized in your GP panel work (PR #311)? |
Hi @timryanb I should be able to review it later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I really like the increased modularity as it will be helpful to reduce code duplication in my subclass. Would like to see some results on applying only the stiffener crippling failure on a flat plate pure axial load case to see what the final stiffener aspect ratios are. Just to double check we implemented it correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't mean to click approve on the PR earlier. Want to see printout of the failure values for where stiffener column buckling is active. Also want to see on a flat plate (one TACS component case) when only stiffener crippling mode is active, what is the critical stiffener aspect ratio SAR = stiffenerHeight / stiffenerThick.
@A-CGray if you add a mode and setter for writing out different values to the f5 file or in the DVs (like what I did in my PR), then you can see the failure values. Also, I think you should change the way I did it and have dv1 be argmax(fails) basically so you can see the index of which failure criterion is maximum. |
In that case, let's make this part a separate PR/feature. I'll add it to the issues page |
…bled failure modes
…for disabled failure modes" This reverts commit 8b87c69.
… for disabled failure modes
Just to confirm @timryanb @sean-engelstad , the plan is to merge this PR, then make the necessary updates to #311 and merge that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good to me! We may still want to wait on Tim's review and see if he wants us to do some comparisons of predicted buckling loads and optimized designs btw the two classes here.
That's fine by me @A-CGray @sean-engelstad. I'd still like to see a benchmark comparison between the two classes for the same model. |
Sure, for reference @sean-engelstad , here are the results with my constitutive model: Fixed stiffener pitch no stiffener crippling constraint
Fixed stiffener pitch with stiffener crippling constraint
With stiffener pitch DV, no stiffener crippling
With stiffener pitch DV and stiffener crippling
|
This PR contains various improvements to the
TACSBladeStiffenedShellConstitutive
constitutive class:setFailureModes
methodevalFailure
and failure sensitivity methods, I have moved the global and local panel buckling calculations to their own methods. This should reduce the amount of code duplication required in @sean-engelstad 's Gaussian Process Buckling Constraints in Blade Stiffened Shell Constitutive Subclass #311 PR