CCIP-3710 create new custom calldata L1 gas oracle #14710
Draft
+225
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WF: CI Core#528e80aNo errors found in this run. 🎉 |
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
9cdbf76
to
41b5cb9
Compare
matYang
reviewed
Oct 10, 2024
| func (d *daOracleConfig) CustomGasPriceCalldata() string { | ||
| // TODO: CCIP-3710 update once custom calldata oracle is added | ||
| return "" | ||
| if d.c.OracleType != toml.CustomCalldata { |
There was a problem hiding this comment.
this feels off, maybe we can move the Oracle constants into a child daoracle package, or prepend them, smt like DAOracle_CustomCalldata
matYang
reviewed
Oct 10, 2024
| logger logger.SugaredLogger | ||
|
|
||
| daOracleConfig evmconfig.DAOracle | ||
| l1GasPriceMu sync.RWMutex |
There was a problem hiding this comment.
let's remove all references to l1 and use da instead
ogtownsend
force-pushed
the
CCIP-3552-refactor-op-stack-oracle-to-accept-generic-op-l-2-config
branch
2 times, most recently
from
e33bf1e
to
6ab6540
Compare
Base automatically changed from
CCIP-3552-refactor-op-stack-oracle-to-accept-generic-op-l-2-config
to
develop
October 11, 2024 19:07
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
41b5cb9
to
6c8b7f5
Compare
ogtownsend
changed the base branch from
develop
to
chore/move-da-oracle-config-consts
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
6c8b7f5
to
528e80a
Compare
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
528e80a
to
69ab245
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #14599, this PR adds a separate custom L1 oracle specifically for fetching gas prices from a custom contract method rather than baking the logic into the existing OP stack L1 oracle