Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccip: chain reader router discovery function. #14607

Merged
merged 8 commits into from
Oct 1, 2024
Merged

ccip: chain reader router discovery function. #14607

merged 8 commits into from
Oct 1, 2024
+61 −18

Conversation

winder
Copy link
Contributor

@winder winder commented Sep 30, 2024 •
edited
Loading

Add new function to onramp chain reader config for discovering destination router.

Misc cleanup for naming conventions.

winder
winder commented Sep 30, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@winder winder marked this pull request as ready for review October 1, 2024 12:47
@winder winder requested review from a team as code owners October 1, 2024 12:47
@winder winder requested review from krehermann and removed request for a team October 1, 2024 12:47
@winder winder changed the title Add new ccip chain reader configs. ccip: chain reader router discovery function. Oct 1, 2024
@winder @makramkd
Update core/capabilities/ccip/configs/evm/contract_reader.go
7f48643 
Co-authored-by: Makram <makramkd@users.noreply.github.com>
asoliman92
asoliman92 previously approved these changes Oct 1, 2024
View reviewed changes
@winder winder enabled auto-merge October 1, 2024 15:35
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
5 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@winder winder added this pull request to the merge queue Oct 1, 2024
Merged via the queue into develop with commit eec0ff9 Oct 1, 2024
147 checks passed
@winder winder deleted the will/ccip-router branch October 1, 2024 18:40
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Draft
@winder winder restored the will/ccip-router branch October 7, 2024 14:36
This was referenced Oct 8, 2024
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asoliman92 asoliman92 asoliman92 approved these changes

@makramkd makramkd makramkd approved these changes

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winder @asoliman92 @makramkd