Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCFR-948 make persistence for HeadTracker optional #14558

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

dhaidashenko
Copy link
Collaborator

@dhaidashenko dhaidashenko commented Sep 25, 2024

Added config option that allows disabling persistence for HeadTracker.
The persistence layer does not improve the chain's load time on chains with fast finality and only consumes database resources (mainly IO).
Persistence should not be disabled for products that use LogBroadcaster, as it might lead to missed on-chain events.

@dhaidashenko dhaidashenko marked this pull request as ready for review September 26, 2024 13:54
@dhaidashenko dhaidashenko requested review from a team as code owners September 26, 2024 13:54
@dhaidashenko dhaidashenko requested review from ilija42 and removed request for a team September 26, 2024 13:54
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dimriou dimriou added this pull request to the merge queue Sep 27, 2024
Merged via the queue into develop with commit 133e347 Sep 27, 2024
147 checks passed
@dimriou dimriou deleted the feature/BCFR-948-ht-optional-persistence branch September 27, 2024 14:11
AnieeG pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants