Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate config on NewApplication #12997

Merged

Conversation

george-dorin
Copy link
Contributor

No description provided.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@george-dorin george-dorin marked this pull request as ready for review April 26, 2024 11:49
@george-dorin george-dorin requested a review from a team as a code owner April 26, 2024 11:49
core/cmd/shell.go Outdated Show resolved Hide resolved
@george-dorin george-dorin added this pull request to the merge queue Apr 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2024
@jmank88 jmank88 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into develop with commit 8c8994e Apr 26, 2024
106 checks passed
@jmank88 jmank88 deleted the BCF-3194-toml-config-not-validated-on-application-start branch April 26, 2024 13:12
HenryNguyen5 added a commit that referenced this pull request Apr 27, 2024
This was referenced Apr 27, 2024
DeividasK pushed a commit that referenced this pull request Apr 29, 2024
* validate config on new application spawn

* Add changeset

* Check config only in the rebroadcast-transactions command
github-merge-queue bot pushed a commit that referenced this pull request Apr 29, 2024
* implement update node operators in capability registry

* address PR feedback

* cache owner call

* Validate config on NewApplication (#12997)

* validate config on new application spawn

* Add changeset

* Check config only in the rebroadcast-transactions command

* Configurable Mercury transmitter parameters (#12680)

* Configurable Mercury transmitter parameters

* Changeset

* Remove commented code

* add tag

* Rename

* LogPoller CLI command to resolve reorg greater than finality depth (#12867)

* find lca and remove block after CLI

* fix sort.Find typo

* make RemoveBlocks local cmd

* tests

* added changeset

* added tags to the changeset

* fixed tests

* make cmds, vars cases consistent

* Fix Node Migration Test Check For Versions (#12982)

* fix: prevent query syntax error if allowlist is empty (#12912)

Co-authored-by: Morgan Kuphal <87319522+KuphJr@users.noreply.github.com>

* Update wrappers

* Formatting

---------

Co-authored-by: george-dorin <120329946+george-dorin@users.noreply.github.com>
Co-authored-by: Sam <samsondav@protonmail.com>
Co-authored-by: Dmytro Haidashenko <34754799+dhaidashenko@users.noreply.github.com>
Co-authored-by: Tate <tate.exon@smartcontract.com>
Co-authored-by: Gabriel Paradiso <gabriel.paradiso@smartcontract.com>
Co-authored-by: Morgan Kuphal <87319522+KuphJr@users.noreply.github.com>
Co-authored-by: DeividasK <deividas.karzinauskas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants