minor improvements on contracts #12944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanRHall
requested changes
Apr 25, 2024
| @@ -1115,13 +1116,12 @@ abstract contract AutomationRegistryBase2_3 is ConfirmedOwner { | |||
| * @notice updates the signers and transmitters lists | |||
| */ | |||
| function _updateTransmitters(address[] memory signers, address[] memory transmitters) internal { | |||
| uint256 transmittersListLength = s_transmittersList.length; | |||
There was a problem hiding this comment.
nitpick - could we make this a uint96 so that we don't have to cast it every time in the loop below? I think it will save a touch on gas
| @@ -198,6 +198,7 @@ contract AutomationRegistryLogicA2_3 is AutomationRegistryBase2_3, Chainable { | |||
| delete s_upkeepOffchainConfig[id]; | |||
| // nullify existing proposed admin change if an upkeep is being migrated | |||
| delete s_proposedAdmin[id]; | |||
| delete s_upkeepAdmin[id]; | |||
RyanRHall
previously approved these changes
Apr 25, 2024
|
cmalec
approved these changes
Apr 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 25, 2024
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.