-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to add a node operator #12906
Add functions to add a node operator #12906
Conversation
I see you updated files related to |
/// @param admin The address of the admin that can manage the node | ||
/// operator | ||
/// @param name The human readable name of the node operator | ||
function addNodeOperator(address admin, string calldata name) external; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of updating this function signature to accept an array of NodeOperator
structs so that multiple node operators can be added in a single transaction. This may be easier if we remove the id
field from the NodeOperator
struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of updating this function signature to accept an array of NodeOperator structs so that multiple node operators can be added in a single transaction.
👍 makes sense.
This may be easier if we remove the id field from the NodeOperator struct.
I'm not sure I understand how this makes it easier. Could you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So keeping the id
field would mean that we need to define a new struct
struct NodeOperatorArgs {
address admin;
string name;
}
which we then pass in to the addNodeOperators(NodeOperatorArgs[] calldata nodeOperators)
function as we only want the admin
and name
fields. I guess the alternative would be to just pass in NodeOperator
instances with the id
field but just ignore it.
Go solidity wrappers are out-of-date, regenerate them via the |
contracts/src/v0.8/keystone/test/CapabilityRegistry_AddNodeOperatorTest.t.sol
Outdated
Show resolved
Hide resolved
34b8380
to
71e2bda
Compare
Go solidity wrappers are out-of-date, regenerate them via the |
1 similar comment
Go solidity wrappers are out-of-date, regenerate them via the |
Go solidity wrappers are out-of-date, regenerate them via the |
d5b2d47
to
ffd96ef
Compare
Go solidity wrappers are out-of-date, regenerate them via the |
3b5a160
to
92990b9
Compare
Go solidity wrappers are out-of-date, regenerate them via the |
1 similar comment
Go solidity wrappers are out-of-date, regenerate them via the |
92990b9
to
9b6ac59
Compare
Go solidity wrappers are out-of-date, regenerate them via the |
I see you updated files related to
|
c346a9b
to
65f986d
Compare
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
65f986d
to
eaaaad4
Compare
…pability-registry
Quality Gate passedIssues Measures |
No description provided.