-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/services/keeper: switch to sqlutil.DataSource #12820
Conversation
I see you updated files related to
|
776059d
to
8382191
Compare
8382191
to
edaa856
Compare
edaa856
to
e27f8d8
Compare
e27f8d8
to
750583f
Compare
Quality Gate passedIssues Measures |
case chSyncUpkeepQueue <- struct{}{}: | ||
go rs.syncUpkeepWithCallback(&rs.registryWrapper, reg, &newUpkeeps[i], done) | ||
wg.Add(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to incremental so we can still Wait()
after context is closed for goroutines to return.
https://smartcontract-it.atlassian.net/browse/BCF-2978