Validate user email before asking for a password. #12767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
pavel-raykov
force-pushed
the
task/1831-email-earliy-validation
branch
from
a40616b
to
be28386
Compare
pavel-raykov
force-pushed
the
task/1831-email-earliy-validation
branch
from
be28386
to
3190138
Compare
Signed-off-by: pavel-raykov <pavel.raykov@smartcontract.com>
|
george-dorin
approved these changes
Apr 10, 2024
This was referenced Apr 10, 2024
This was referenced Apr 12, 2024
This was referenced Apr 15, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the following feature request https://smartcontract-it.atlassian.net/browse/BCF-1831.
Note that there is no need to explicitly test for the incorrect email since the verification function ParseAddress in net/mail/message.go (https://pkg.go.dev/net/mail#ParseAddress) is already thoroughly tested.