Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the gas estimator components refactor #12650

Merged
merged 37 commits into from
Apr 18, 2024
Merged

Implement the gas estimator components refactor #12650

merged 37 commits into from
Apr 18, 2024

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Apr 1, 2024 •
edited
Loading

Implementing to Gas Estimator Refactors as outlined in this document.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

@silaslenihan silaslenihan force-pushed the BCI-2717-Implement-the-gas-estimator-components-refactor branch from fc9d345 to d9a484f Compare April 3, 2024 20:50
@silaslenihan silaslenihan force-pushed the BCI-2717-Implement-the-gas-estimator-components-refactor branch from d205e9e to 904126e Compare April 4, 2024 15:34
@silaslenihan silaslenihan force-pushed the BCI-2717-Implement-the-gas-estimator-components-refactor branch from 904126e to e759faa Compare April 4, 2024 15:44
@silaslenihan silaslenihan marked this pull request as ready for review April 4, 2024 16:15
@silaslenihan silaslenihan requested a review from a team as a code owner April 4, 2024 16:15
@silaslenihan silaslenihan force-pushed the BCI-2717-Implement-the-gas-estimator-components-refactor branch from 07ec9da to d772bd1 Compare April 4, 2024 16:27
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
3 New issues
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
83.5% Coverage on New Code
3.2% Duplication on New Code

See analysis details on SonarQube

@dimriou dimriou added this pull request to the merge queue Apr 18, 2024
Merged via the queue into develop with commit 6991af2 Apr 18, 2024
105 checks passed
@dimriou dimriou deleted the BCI-2717-Implement-the-gas-estimator-components-refactor branch April 18, 2024 15:39
This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimriou dimriou dimriou approved these changes

@amit-momin amit-momin amit-momin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silaslenihan @dimriou @amit-momin