-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VRF-922-VRF-V2-Plus-Wrapper-combine-SetLink-and-SetLinkEthFeed-functions-into-one-function #12368
VRF-922-VRF-V2-Plus-Wrapper-combine-SetLink-and-SetLinkEthFeed-functions-into-one-function #12368
Conversation
I see that you haven't updated any README files. Would it make sense to do so? |
LGTM. We will also emit an event for this setter once #12318 is merged right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the only optional thing would be to add the unit test, since we are doing this for every method.
@jinhoonbang Yup, probably will merge conflict. Will resolve in that PR. |
@ibrajer The test is updated in this PR. |
…nk-and-SetLinkEthFeed-functions-into-one-function
Quality Gate passedIssues Measures |
Combine setLink and setLinkNativeFeed into a single function