VRF-881: fixed toml config for VRF Load tests; VRF-882: add more cust… #11991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omisation options for BHS job in super scripts
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
Tofel
reviewed
Feb 12, 2024
vreff
reviewed
Feb 13, 2024
Tofel
reviewed
Feb 23, 2024
Tofel
reviewed
Feb 23, 2024
| subscription, err := vrfContracts.CoordinatorV2Plus.GetSubscription(testcontext.Get(t), subID) | ||
| require.NoError(t, err, "error getting subscription information") | ||
|
|
||
| vrfv2plus.LogSubDetails(l, subscription, subID, vrfContracts.CoordinatorV2Plus) |
There was a problem hiding this comment.
put this snippet in a dedicated function? seems that it's copy & pasted at least 2x
There was a problem hiding this comment.
not sure about which snippet part you are referring to?
|
Tofel
approved these changes
Feb 26, 2024
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
#11991) * VRF-881: fixed toml config for VRF Load tests; VRF-882: add more customisation options for BHS job in super scripts * VRF-881: fixing lint * VRF-881: upgrading ctf library * VRF-881: adding load test metric calculation in seconds for VRF V2Plus Consumer contract; adding more parametrization options in setup-env script * VRF-881: PR comments; * VRF-881: fixing Lint issues * VRF-881: fixing BHS tests * VRF-881: adding smoke test type * VRF-881: PR comments * VRF-881: fixing load test * VRF-881: fixing config * VRF-881: fixing e2e tests * VRF-881: fixing sonar * VRF-881: fixing sonar and refactoring * VRF-881: fixing lint issues
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
#11991) * VRF-881: fixed toml config for VRF Load tests; VRF-882: add more customisation options for BHS job in super scripts * VRF-881: fixing lint * VRF-881: upgrading ctf library * VRF-881: adding load test metric calculation in seconds for VRF V2Plus Consumer contract; adding more parametrization options in setup-env script * VRF-881: PR comments; * VRF-881: fixing Lint issues * VRF-881: fixing BHS tests * VRF-881: adding smoke test type * VRF-881: PR comments * VRF-881: fixing load test * VRF-881: fixing config * VRF-881: fixing e2e tests * VRF-881: fixing sonar * VRF-881: fixing sonar and refactoring * VRF-881: fixing lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…omisation options for BHS job in super scripts