core/services/relay/evm: start RequestRoundTracker; report full health #11643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
nolag
previously approved these changes
Dec 21, 2023
| require.NoError(t, err, "Error starting new OCR2 round") | ||
| roundData, err := aggregatorContracts[0].GetRound(testcontext.Get(t), big.NewInt(int64(round))) | ||
| require.NoError(t, err, "Getting latest answer from OCR contract shouldn't fail") | ||
| require.Equal(t, int64(5), roundData.Answer.Int64(), |
There was a problem hiding this comment.
Seems like we should also assert that roundData.RoundId is the correct round, right?
As a side note, I just noticed there is a roundData.AnsweredInRound field--probably moot now, but I wonder if that could have helped determine whether we were getting an answer from the current round or the previous round.
There was a problem hiding this comment.
We're kind of implicitly doing that already. We only stop waiting when round number round appears, then we grab data from specifically that round.
|
SonarQube Quality Gate
|
jmank88
requested review from
reductionista,
nolag,
kalverra,
connorwstein and
a team
kalverra
approved these changes
Dec 21, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Revert "make streams lookup modular (#11368)" (#11482) This reverts commit fa0f16a. * core/services/relay/evm: start RequestRoundTracker; report full health (#11643) * core/services/relay/evm: start RequestRoundTracker; report full health * Tests round requests and implicit changes separately * Add test to CI * Fixes other OCR2 checks --------- Co-authored-by: Adam Hamrick <adam.hamrick@smartcontract.com> (cherry picked from commit 7236361) * Document metrics renaming * Hotfix attempt for Canary : v2.8.0-rc0 upgrade fails on Polygon. (#11828) (#11839) * Remove start lock + add logging * Add loggs * Update tracker.go * Update tracker.go * Update common/txmgr/txmgr.go Co-authored-by: Jordan Krage <jmank88@gmail.com> * Update logging --------- Co-authored-by: Jordan Krage <jmank88@gmail.com> (cherry picked from commit 6133df8) * Temporarily disable tracker (#11857) * Disable tracker * Remove all tracker calls (cherry picked from commit 5057899) * Update CHANGELOG.md * Update docs/CHANGELOG.md Co-authored-by: Jordan Krage <jmank88@gmail.com> * Finalize date on changelog for 2.8.0 (#11881) --------- Co-authored-by: Lei <lei.shi@smartcontract.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Dmytro Haidashenko <dmytro.haidashenko@smartcontract.com> Co-authored-by: Dylan Tinianov <dylantinianov@gmail.com> Co-authored-by: Dylan Tinianov <dylan.tinianov@smartcontract.com>
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2860