Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/services/synchronization: track go routines to block close #11443

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 1, 2023

No description provided.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

I see that you haven't updated any README files. Would it make sense to do so?

ilija42
ilija42 previously approved these changes Dec 1, 2023
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't harm anything, lets ship it and see if the race shows up again ¯_(ツ)_/¯

@jmank88 jmank88 marked this pull request as ready for review December 1, 2023 15:21
@jmank88 jmank88 added this pull request to the merge queue Dec 1, 2023
@cl-sonarqube-production
Copy link

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2023
@jmank88 jmank88 added this pull request to the merge queue Dec 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2023
@jmank88 jmank88 added this pull request to the merge queue Dec 1, 2023
Merged via the queue into develop with commit abac315 Dec 1, 2023
85 checks passed
@jmank88 jmank88 deleted the telem-clients-wg branch December 1, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants