Small cleanup in mercury v0.3 request code #11442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
infiloop2
commented
Dec 1, 2023
| c.threadCtrl.Go(func(ctx context.Context) { | ||
| c.multiFeedsRequest(ctx, ch, streamsLookup) | ||
| }) | ||
|
|
||
| var reqErr error | ||
| var retryInterval time.Duration | ||
| results := make([][]byte, len(streamsLookup.Feeds)) | ||
| retryable := true | ||
| allSuccess := true |
There was a problem hiding this comment.
no longer need to have logic for allSuccess since we don't have a loop and its based on single result
infiloop2
commented
Dec 1, 2023
| c.threadCtrl.Go(func(ctx context.Context) { | ||
| c.multiFeedsRequest(ctx, ch, streamsLookup) | ||
| }) | ||
|
|
||
| var reqErr error | ||
| var retryInterval time.Duration | ||
| results := make([][]byte, len(streamsLookup.Feeds)) | ||
| retryable := true | ||
| allSuccess := true | ||
| retryable := false |
There was a problem hiding this comment.
no longer need to start with true and keep doing && within loop
If the single request fails then we'll set the retryable value, else it's false by default
infiloop2
commented
Dec 1, 2023
| if len(streamsLookup.Feeds) == 0 { | ||
| return mercury.NoPipelineError, mercury.MercuryUpkeepFailureReasonInvalidRevertDataInput, [][]byte{}, false, 0 * time.Second, fmt.Errorf("invalid revert data input: feed param key %s, time param key %s, feeds %s", streamsLookup.FeedParamKey, streamsLookup.TimeParamKey, streamsLookup.Feeds) | ||
| } | ||
| resultLen = 1 | ||
| resultLen := 1 // Only 1 multi-feed request is made for all feeds | ||
| ch := make(chan mercury.MercuryData, resultLen) |
There was a problem hiding this comment.
previously a larger size channel was being made than was necessary (only 1 value was written to it). Reducing this shouldn't have any effect
|
SonarQube Quality Gate
|
FelixFan1992
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-7930
Doing a minor cleanup in mercury v0.3 code post refactor
Since it only does one request, it doesn't need to wait for results in a loop. Aggregation of retryable/success values also becomes easier as no aggregation is required, rather it just depends on a single value now
Test plan:
Rely on exisitng CI tests for mercury 0.3 path and also code review as it's a small change