Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FUN-1094] Resolve informational finding from audit #11429

Closed
wants to merge 9 commits into from

Conversation

agparadiso
Copy link
Contributor

@agparadiso agparadiso commented Nov 30, 2023

Description

This mr addresses the findings from the v1.0.0 contract audit more info here [FUN-1094](https://smartcontract-it.atlassian.net/browse/FUN-1094).

  • Each of the 4 points have been addressed on separate commits in order to make review simpler.
  • The only change that affects logic is the one that does not emits the event AddedAccess(recipient) event if the recipient already has access. In order to validate this works as expected, now the test validate that the log does not contains new events after calling the function.

ℹ️ I've marked the mr as draft until Im able to sign the commits, will rebase an sign once I get access

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@agparadiso agparadiso self-assigned this Nov 30, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@justinkaseman justinkaseman changed the title [FUN-1094] Resolve informational finding from SP contract audit [FUN-1094] Resolve informational finding from audit Nov 30, 2023
@agparadiso agparadiso closed this Nov 30, 2023
@agparadiso agparadiso deleted the chore/fun-1094_resolve_sp_contract_audit branch November 30, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant