Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/chains/evm/txmgr: nil check errs before wrapping #11412

Merged
merged 1 commit into from
Nov 29, 2023
Merged

core/chains/evm/txmgr: nil check errs before wrapping #11412

merged 1 commit into from
Nov 29, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 29, 2023

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 requested review from DylanTinianov and a team November 29, 2023 16:15
@jmank88 jmank88 marked this pull request as ready for review November 29, 2023 16:16
samsondav
samsondav previously requested changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include a regression test? Seems like there was a gap in our coverage for these cases.

@jmank88
Copy link
Contributor Author

jmank88 commented Nov 29, 2023

Can we include a regression test? Seems like there was a gap in our coverage for these cases.

@samsondav Mind if we circle back in another PR? Trying to unblock @chudilka1 's testing

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jmank88 jmank88 dismissed samsondav’s stale review November 29, 2023 19:47

Circling back for tests

@jmank88 jmank88 added this pull request to the merge queue Nov 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2023
@jmank88 jmank88 added this pull request to the merge queue Nov 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2023
@jmank88 jmank88 added this pull request to the merge queue Nov 29, 2023
Merged via the queue into develop with commit c36340c Nov 29, 2023
88 checks passed
@jmank88 jmank88 deleted the BCF-2830-txm-errs branch November 29, 2023 20:35
@dmitry-diginex dmitry-diginex mentioned this pull request Dec 3, 2023
Open
fbac pushed a commit that referenced this pull request Dec 14, 2023
@jmank88
core/chains/evm/txmgr: nil check errs before wrapping (#11412)
b7cb603
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@DylanTinianov DylanTinianov DylanTinianov approved these changes

@samsondav samsondav samsondav left review comments

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmank88 @samsondav @vyzaldysanchez @patrickhuie19 @DylanTinianov