CCIP-1230 Exposing entire LogPollerBlock from LatestBlock in LogPoller #11105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
mateusz-sekara
force-pushed
the
lp/latest-block-fetch
branch
from
f7311c3
to
eb14bee
Compare
mateusz-sekara
changed the title
mateusz-sekara
force-pushed
the
lp/latest-block-fetch
branch
from
eb14bee
to
59810ac
Compare
mateusz-sekara
force-pushed
the
lp/latest-block-fetch
branch
5 times, most recently
from
294b057
to
18f971f
Compare
mateusz-sekara
force-pushed
the
lp/latest-block-fetch
branch
from
18f971f
to
f40c5f3
Compare
mateusz-sekara
requested review from
bolekk,
justinkaseman,
KuphJr,
a team,
samsondav,
sdrug,
martin-cll,
reductionista and
connorwstein
as code owners
|
SonarQube Quality Gate
|
bolekk
pushed a commit
that referenced
this pull request
Nov 6, 2023
#11105) * Exposing entire LogPollerBlock from LatestBlock function in the LogPoller's interface * Exposing entire LogPollerBlock from LatestBlock function in the LogPoller's interface
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
#11105) * Exposing entire LogPollerBlock from LatestBlock function in the LogPoller's interface * Exposing entire LogPollerBlock from LatestBlock function in the LogPoller's interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIth support for finality introduced here #10762, we can expose finalized block from the LogPoller's API as well.
Reusing an existing function seems reasonable because:
GetBlocksRangewhich returns entire blockLogPollerBlockinstead of their numbers