Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCI-2313] Rename L2Suggested to SuggestedPrice #11093

Merged
merged 30 commits into from
Nov 1, 2023
Merged

[BCI-2313] Rename L2Suggested to SuggestedPrice #11093

merged 30 commits into from
Nov 1, 2023

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Oct 26, 2023 •
edited
Loading

Rename L2Suggested mode to SuggestedPrice since it works for non-L2 chains as well.

  • Node configs use new mode name for NOPs and Clusters
  • All docs are updated with the change
  • Jobs are updated
  • Instances of L2Suggested updated everywhere in code
  • Sanity/Soak testing done for all affected chains
  • Coordinated with engops/infra regarding config changes

@DylanTinianov DylanTinianov self-assigned this Oct 26, 2023
@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@DylanTinianov DylanTinianov changed the title Rename L2Suggested to SuggestedPrice [BCI-2313] Rename L2Suggested to SuggestedPrice Oct 26, 2023
@DylanTinianov DylanTinianov marked this pull request as ready for review October 27, 2023 14:53
@DylanTinianov DylanTinianov marked this pull request as draft October 27, 2023 18:25
@DylanTinianov DylanTinianov marked this pull request as ready for review October 30, 2023 18:01
@dimriou
Copy link
Collaborator

dimriou commented Oct 30, 2023

Can you also update the CHANGELOG and describe what changed?

jmank88
jmank88 reviewed Oct 30, 2023
View reviewed changes
docs/CHANGELOG.md Outdated Show resolved Hide resolved
amit-momin
amit-momin requested changes Oct 30, 2023
View reviewed changes
core/chains/evm/gas/suggested_price_estimator.go Outdated Show resolved Hide resolved
core/chains/evm/gas/suggested_price_estimator_test.go Outdated Show resolved Hide resolved
core/chains/evm/gas/suggested_price_estimator.go Outdated Show resolved Hide resolved
core/chains/evm/gas/suggested_price_estimator.go Outdated Show resolved Hide resolved
core/chains/evm/gas/suggested_price_estimator.go Show resolved Hide resolved
core/chains/evm/gas/suggested_price_estimator.go Show resolved Hide resolved
amit-momin
amit-momin reviewed Oct 30, 2023
View reviewed changes
docs/CHANGELOG.md Outdated Show resolved Hide resolved
amit-momin
amit-momin previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the discussion on Optimism2 is settled, I think this looks good

prashantkumar1982
prashantkumar1982 reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 minor comment

core/config/docs/chains-evm.toml Show resolved Hide resolved
prashantkumar1982
prashantkumar1982 previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Nov 1, 2023
Merged via the queue into develop with commit 1a69590 Nov 1, 2023
84 checks passed
@prashantkumar1982 prashantkumar1982 deleted the chore/rename-l2suggested-mode branch November 1, 2023 21:26
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 left review comments

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@amit-momin amit-momin amit-momin left review comments

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

@dimriou dimriou Awaiting requested review from dimriou

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DylanTinianov @dimriou @jmank88 @prashantkumar1982 @amit-momin