Revert "fix: prevent query syntax error if allowlist is empty (#12912)"

This reverts commit b1c8d74.
smartcontractkit · Apr 27, 2024 · ae7884d · ae7884d
1 parent ee9ea07
commit ae7884d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/core/services/gateway/handlers/functions/allowlist/orm.go b/core/services/gateway/handlers/functions/allowlist/orm.go
@@ -67,11 +67,6 @@ func (o *orm) GetAllowedSenders(ctx context.Context, offset, limit uint) ([]comm
 }
 
 func (o *orm) CreateAllowedSenders(ctx context.Context, allowedSenders []common.Address) error {
-	if len(allowedSenders) == 0 {
-		o.lggr.Debugf("empty allowed senders list: %v for routerContractAddress: %s. skipping...", allowedSenders, o.routerContractAddress)
-		return nil
-	}
-
 	var valuesPlaceholder []string
 	for i := 1; i <= len(allowedSenders)*2; i += 2 {
 		valuesPlaceholder = append(valuesPlaceholder, fmt.Sprintf("($%d, $%d)", i, i+1))

diff --git a/core/services/gateway/handlers/functions/allowlist/orm_test.go b/core/services/gateway/handlers/functions/allowlist/orm_test.go
@@ -128,15 +128,6 @@ func TestORM_CreateAllowedSenders(t *testing.T) {
 		require.Equal(t, expected[0], results[0])
 		require.Equal(t, expected[1], results[1])
 	})
-
-	// this scenario can happen if the allowlist is empty but we call CreateAllowedSenders
-	t.Run("OK-empty_list", func(t *testing.T) {
-		ctx := testutils.Context(t)
-		orm, err := setupORM(t)
-		require.NoError(t, err)
-		err = orm.CreateAllowedSenders(ctx, []common.Address{})
-		require.NoError(t, err)
-	})
 }
 
 func TestORM_DeleteAllowedSenders(t *testing.T) {