Add tests for MustGetSelectedNetworksFromEnv and NewEVMNetwork #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukaszcl
commented
Oct 27, 2023
•
lukaszcl
commented
- add tests for NewEVMNetwork
lukaszcl
requested review from
sebawo,
skudasov,
kalverra,
tateexon,
AnieeG,
gheorghestrimtu and
Tofel
as code owners
lukaszcl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
+ Coverage 21.57% 22.58% +1.00%
==========================================
Files 31 32 +1
Lines 4167 4251 +84
==========================================
+ Hits 899 960 +61
- Misses 3177 3193 +16
- Partials 91 98 +7 ☔ View full report in Codecov by Sentry. |
tateexon
suggested changes
Oct 27, 2023
lukaszcl
force-pushed
the
add-tests-for-MustGetSelectedNetworksFromEnv
branch
from
1d6f19e
to
3868cec
Compare
lukaszcl
changed the title
tateexon
approved these changes
Oct 27, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.