Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-561] move chainlink-env as a package #743

Closed
wants to merge 26 commits into from
Closed

[TT-561] move chainlink-env as a package #743

wants to merge 26 commits into from

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Oct 20, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1858011) 21.43% compared to head (2870b79) 21.61%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   21.43%   21.61%   +0.18%     
==========================================
  Files          31       32       +1     
  Lines        4167     4183      +16     
==========================================
+ Hits          893      904      +11     
- Misses       3182     3186       +4     
- Partials       92       93       +1
Files Coverage Δ
blockchain/ethereum.go 0.00% <ø> (ø)
client/mockserver.go 39.69% <ø> (ø)
client/postgres.go 0.00% <ø> (ø)
logging/log.go 43.47% <ø> (ø)
env/config/overrides.go 68.75% <68.75%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnieeG
Copy link
Contributor

AnieeG commented Oct 20, 2023

is there a way to break this up in multiple PRs?

@Tofel Tofel temporarily deployed to integration October 20, 2023 15:32 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 23, 2023 08:52 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 23, 2023 08:58 — with GitHub Actions Inactive
@Tofel Tofel marked this pull request as draft October 23, 2023 09:20
@Tofel Tofel temporarily deployed to integration October 23, 2023 09:21 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 23, 2023 09:21 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 23, 2023 09:57 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 23, 2023 09:57 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 23, 2023 10:08 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 23, 2023 10:08 — with GitHub Actions Inactive
@tateexon tateexon temporarily deployed to integration October 23, 2023 19:00 — with GitHub Actions Inactive
@tateexon tateexon temporarily deployed to integration October 23, 2023 19:00 — with GitHub Actions Inactive
@tateexon tateexon temporarily deployed to integration October 23, 2023 19:07 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 24, 2023 08:18 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration October 24, 2023 08:18 — with GitHub Actions Inactive
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots (100.0% 100.0% reviewed)
Code Smell A 908 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@Tofel Tofel temporarily deployed to integration October 24, 2023 08:25 — with GitHub Actions Inactive
@Tofel
Copy link
Contributor Author

Tofel commented Oct 24, 2023

Moved to #747 where changes are better visible

@Tofel Tofel closed this Oct 24, 2023
@tateexon tateexon deleted the tt_651_migrate_chainlink_env branch April 18, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tateexon tateexon tateexon left review comments

@sebawo sebawo Awaiting requested review from sebawo sebawo is a code owner

@skudasov skudasov Awaiting requested review from skudasov

@kalverra kalverra Awaiting requested review from kalverra

@AnieeG AnieeG Awaiting requested review from AnieeG

@gheorghestrimtu gheorghestrimtu Awaiting requested review from gheorghestrimtu

@lukaszcl lukaszcl Awaiting requested review from lukaszcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tofel @codecov-commenter @AnieeG @tateexon