Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind this In Pilet API Event Functions #665

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Bind this In Pilet API Event Functions #665

merged 3 commits into from
Jan 17, 2024

Conversation

manuelroemer
Copy link
Member

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Fixes #664.

Remarks

None.

@manuelroemer manuelroemer added bug Something isn't working core Concerns the piral-core library. labels Jan 17, 2024
@manuelroemer manuelroemer added this to the 1.5.0 milestone Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

File size impact

Merging fix/#644 into develop impact files as follow:

empty-piral (-0.06%)
Files new size
src/samples/empty-piral/dist/release/index.1de100.js 29.6 kB 👶
src/samples/empty-piral/dist/release/index.18a434.js deleted (-29.6 kB)
src/samples/empty-piral/dist/release/index.html 315 B (0 B / +0%) 👻
Total (3) 29.9 kB (-18 B / -0.06%) ↘️
minimal-piral (-0.01%)
Files new size
src/samples/minimal-piral/dist/release/index.f1d72e.js 277 kB 👶
src/samples/minimal-piral/dist/release/index.6523a1.js deleted (-277 kB)
src/samples/minimal-piral/dist/release/index.html 315 B (0 B / +0%) 👻
Total (3) 278 kB (-18 B / -0.01%) ↘️
sample-cross-fx (-0%)
Files new size
src/samples/sample-cross-fx/dist/release/index.9b0bd9.js 2.23 MB 👶
src/samples/sample-cross-fx/dist/release/main.2ed1f6.css 1.67 kB 👶
src/samples/sample-cross-fx/dist/release/main.85a2af.css deleted (-1.67 kB)
src/samples/sample-cross-fx/dist/release/index.7f378a.js deleted (-2.23 MB)
src/samples/sample-cross-fx/dist/release/index.html 454 B (0 B / +0%) 👻
Total (5) 2.23 MB (-14 B / -0%) ↘️
sample-piral (-0%)
Files new size
src/samples/sample-piral/dist/release/index.d64ddb.js 527 kB 👶
src/samples/sample-piral/dist/release/main.7acfc3.css 170 kB 👶
src/samples/sample-piral/dist/release/main.f1b976.css deleted (-170 kB)
src/samples/sample-piral/dist/release/index.43e53c.js deleted (-527 kB)
src/samples/sample-piral/dist/release/index.html 490 B (0 B / +0%) 👻
Total (5) 697 kB (-18 B / -0%) ↘️
sample-piral-core (-0.01%)
Files new size
src/samples/sample-piral-core/dist/release/index.92d54c.js 351 kB 👶
src/samples/sample-piral-core/dist/release/main.4d6da5.css 3.6 kB 👶
src/samples/sample-piral-core/dist/release/main.572b68.css deleted (-3.6 kB)
src/samples/sample-piral-core/dist/release/index.06275b.js deleted (-351 kB)
src/samples/sample-piral-core/dist/release/index.html 436 B (0 B / +0%) 👻
Total (5) 355 kB (-18 B / -0.01%) ↘️
Generated by @jsenv/file-size-impact during check-bundle-size#7558253187 on 029b6d7

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FlorianRappl FlorianRappl merged commit 6429391 into develop Jan 17, 2024
6 checks passed
@FlorianRappl FlorianRappl deleted the fix/#644 branch January 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Concerns the piral-core library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PiletApi's once throws when this context is undefined
2 participants