Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Middleware Functions in piral-fetch #655

Merged
merged 9 commits into from
Dec 13, 2023

Conversation

manuelroemer
Copy link
Member

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Implements the proposed piral-fetch middleware changes from #645. See the issue for details.

Remarks

None.

@manuelroemer manuelroemer added enhancement New feature or request plugin Covered by an opt-in plugin for Piral. labels Dec 13, 2023
@FlorianRappl FlorianRappl added this to the 1.4.1 milestone Dec 13, 2023
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we still need an entry in the CHANGELOG.md (this is for the new 1.4.1 - so a new entry is needed; first pull from documentation to have the most recent develop branch)

@manuelroemer
Copy link
Member Author

manuelroemer commented Dec 13, 2023

Ok, will do. IIRC the next title in the changelog should then be ## 1.4.1 (tbd), right? Let me know if not. ;)

@FlorianRappl
Copy link
Contributor

Ok, will do. IIRC the next title in the changelog should then be ## 1.4.1 (tbd), right? Let me know if not. ;)

Yes that is right

@FlorianRappl FlorianRappl linked an issue Dec 13, 2023 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
@FlorianRappl FlorianRappl merged commit dc9791a into develop Dec 13, 2023
5 of 6 checks passed
@manuelroemer manuelroemer deleted the feature/piral-fetch-middlewares branch December 13, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin Covered by an opt-in plugin for Piral.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support User-Defined Middleware Functions in piral-fetch
2 participants