Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improved pilet pack command #630

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Conversation

FlorianRappl
Copy link
Contributor

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Fixes #629 and improves the pilet pack command by not requiring the temp dir / copy.

Remarks

I think overall this is much better than beforehand.

@FlorianRappl FlorianRappl added the cli Concerns the piral-cli application. label Oct 1, 2023
@FlorianRappl FlorianRappl added this to the 1.3.0 milestone Oct 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

File size impact

Merging hotfix/#629-dir-entries into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.7 kB (0 B / +0%) 👻
Total (2) 28.7 kB (0 B / +0%) 👻
minimal-piral (no impact)
Files new size
Unmodified (2) 252 kB (0 B / +0%) 👻
Total (2) 252 kB (0 B / +0%) 👻
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.17 MB (0 B / +0%) 👻
Total (3) 2.17 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 640 kB (0 B / +0%) 👻
Total (3) 640 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 305 kB (0 B / +0%) 👻
Total (3) 305 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during check-bundle-size#6371155251 on 79097cd

@FlorianRappl FlorianRappl merged commit 05f6c11 into develop Oct 1, 2023
4 of 6 checks passed
@FlorianRappl FlorianRappl deleted the hotfix/#629-dir-entries branch November 2, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Concerns the piral-cli application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pilet pack/tgz format includes entries for directories starting in version 0.15.x
1 participant