Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding abort signal #622

Conversation

phildaniels
Copy link
Contributor

@phildaniels phildaniels commented Aug 23, 2023

New Pull Request

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Adds abort signal as option to fetch function so it can be forwarded to native fetch

Remarks

I didn't add any tests because there were no existing tests for the files I modified

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

File size impact

Merging feature/621-add-abort-signal-to-fetch-plugin into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.6 kB (0 B / +0%) 👻
Total (2) 28.6 kB (0 B / +0%) 👻
minimal-piral (no impact)
Files new size
Unmodified (2) 251 kB (0 B / +0%) 👻
Total (2) 251 kB (0 B / +0%) 👻
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.17 MB (0 B / +0%) 👻
Total (3) 2.17 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 639 kB (0 B / +0%) 👻
Total (3) 639 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 305 kB (0 B / +0%) 👻
Total (3) 305 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during check-bundle-size#5957121205 on d9c26c0

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FlorianRappl FlorianRappl merged commit fa4603c into smapiot:develop Aug 24, 2023
6 checks passed
@FlorianRappl FlorianRappl linked an issue Aug 24, 2023 that may be closed by this pull request
@FlorianRappl FlorianRappl added this to the 1.2.0 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add abort signal to piral-fetch fetch options
3 participants