Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificate extract command for conversion between P12, PEM, and DER #589
base: master
Are you sure you want to change the base?
Add certificate extract command for conversion between P12, PEM, and DER #589
Changes from all commits
10e9785
1b8e030
b4ef290
60baaec
b8b593e
28b6b7e
29cb746
9f49147
1f5d33b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like if the flag
--format
is not passed it will write PEM files, as it should be. We should show this in one of these two examples, explaining that is the default behavior.Check warning on line 151 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L143-L151
Check warning on line 155 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L153-L155
Check warning on line 158 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L157-L158
Check warning on line 161 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L160-L161
Check warning on line 166 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L165-L166
Check warning on line 171 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L170-L171
Check warning on line 176 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L173-L176
Check warning on line 183 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L180-L183
Check warning on line 189 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L187-L189
Check warning on line 192 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L191-L192
Check warning on line 196 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L194-L196
Check warning on line 199 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L198-L199
Check warning on line 203 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L202-L203
Check warning on line 207 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L206-L207
Check warning on line 214 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L212-L214
Check warning on line 216 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L216
Check warning on line 220 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L220
Check warning on line 225 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L224-L225
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commands like these will stop working:
Check warning on line 227 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L227
Check warning on line 231 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L230-L231
Check warning on line 233 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L233
Check warning on line 274 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L274
Check warning on line 291 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L291
Check warning on line 294 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L294
Check warning on line 296 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L296
Check warning on line 302 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L299-L302
Check warning on line 307 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L304-L307
Check warning on line 312 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L309-L312
Check warning on line 315 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L315
Check warning on line 326 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L324-L326
Check warning on line 332 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L328-L332
Check warning on line 334 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L334
Check warning on line 337 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L336-L337
Check warning on line 339 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L339
Check warning on line 345 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L342-L345
Check warning on line 348 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L347-L348
Check warning on line 350 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L350
Check warning on line 358 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L353-L358
Check warning on line 361 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L361
Check warning on line 367 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L364-L367
Check warning on line 374 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L369-L374
Check warning on line 380 in command/certificate/format.go
Codecov / codecov/patch
command/certificate/format.go#L376-L380