Fix bug #149: Problem with big hex numbers in windows #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisws
reviewed
Apr 13, 2024
src/common/blib_func.c
Outdated
|
|
||
| var_num_t *m = (var_num_t *)malloc(((rows) * (cols)) * sizeof(var_num_t)); | ||
|
|
||
| for(int32_t x = 0; x < cols; x++) { |
There was a problem hiding this comment.
just a super-nit pik. could u please put a space after for ie for (. same for the if( line below.
There was a problem hiding this comment.
No problem. Space added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
Commit 1:
I fixed bug #149 problem with big hex numbers in windows. The problem is, that Linux 64 bit and Windows 64 bit have different length for long (linux -> 64 bit, windows -> 32 bit). I changed the length to var_int_t. See: https://www.ibm.com/docs/en/ibm-mq/9.1?topic=platforms-standard-data-types-unix-linux-windows
Commit 2:
I added the new SB function TRANSPOSE. It returns the transpose of a Matrix (or vector).
Best regards, Joerg