Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown link action fail #2480

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Fix markdown link action fail #2480

wants to merge 21 commits into from

Conversation

ihasidul
Copy link
Member

No description provided.

@jbampton jbampton added this to In progress in slurp via automation Nov 28, 2023
@ihasidul
Copy link
Member Author

@jbampton Can you please review this and suggest me changes.

jbampton
jbampton reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit is failing at the install step so we can't check if this addition works.

And we also know there are some broken links still.

Seems we need to fix the pre-commit run first. Can be another pr

The pre-commit failure is seen here https://github.com/slurpcode/slurp/actions/runs/7022977508/job/19108441822?pr=2480

Is the failure an issue with Python or Pylint ?

jbampton
jbampton reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can test your work locally by just running the hook you added: "markdown-link-check"

Test with:

pre-commit run markdown-link-check --all-files

@BaseMax
Copy link
Member

BaseMax commented Dec 3, 2023

a reminder

@jbampton jbampton marked this pull request as draft December 5, 2023 16:30
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 5, 2023
@BaseMax
Copy link
Member

BaseMax commented Dec 10, 2023

this pr is draft so close?

@jbampton jbampton marked this pull request as ready for review December 20, 2023 15:00
@jbampton jbampton marked this pull request as draft January 10, 2024 13:10
@BaseMax
Copy link
Member

BaseMax commented Jan 29, 2024

?

@BaseMax
Copy link
Member

BaseMax commented Mar 6, 2024

Conflicting files
.pre-commit-config.yaml

jbampton
jbampton reviewed Apr 5, 2024
View reviewed changes
mlc_config.json Outdated Show resolved Hide resolved
jbampton
jbampton reviewed Apr 5, 2024
View reviewed changes
mlc_config.json Outdated Show resolved Hide resolved
jbampton
jbampton reviewed Apr 5, 2024
View reviewed changes
mlc_config.json Outdated Show resolved Hide resolved
@jbampton jbampton closed this Apr 5, 2024
slurp automation moved this from In progress to Done Apr 5, 2024
@jbampton jbampton reopened this Apr 5, 2024
slurp automation moved this from Done to In progress Apr 5, 2024
@github-actions github-actions bot added the repo label Apr 5, 2024
@jbampton
Copy link
Member

jbampton commented Apr 5, 2024

The PR labeler is now working again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbampton jbampton jbampton left review comments

@BaseMax BaseMax Awaiting requested review from BaseMax BaseMax is a code owner

@smriad smriad Awaiting requested review from smriad smriad is a code owner

@anufdo anufdo Awaiting requested review from anufdo anufdo is a code owner

@ayushrana182 ayushrana182 Awaiting requested review from ayushrana182 ayushrana182 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
actions repo size/M
Projects
slurp
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ihasidul @BaseMax @jbampton @anufdo