Slintpad fixes #6575
Open
Slintpad fixes #6575
+20
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not extract the file loading into a fuinction: That keeps `self` around which is part of a borrowed state. That is a problem as during the load we end up in `ensure_document_loaded` again, which will try to borrow_mut that same state.
Slintpad uses URLs to images. Do not fail when we "embed" those so that we find the list of resources on the Documents later. This fixes image loading in slintpad again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix loading of additional slint source files as well as of urls in
@image-url.This makes the current slintpad render the printerdemo just as slintpad.com does... which still looks like it is missing the tab below the icons. Was that changed?