Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler panic binding to property with syntax error #6572

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ogoffart
Copy link
Member

Fixes #6519

@@ -304,6 +305,9 @@ export component C12 {
in property <bool> in5 <=> inout1;
// ^error{Cannot link input property}

in property <bool> boggus1 <=> btn.internal;
// ^error{The property 'internal' is private. Annotate it with}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if there's something missing here, but I guess it's fine as this is just matching the message, which will be longer than that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i was just lazy to type the full message.

@ogoffart ogoffart merged commit 13d4413 into master Oct 16, 2024
36 checks passed
@ogoffart ogoffart deleted the olivier/fix-#6519 branch October 16, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic assertion failed: lhs_lookup.is_local_to_component in internal/compiler/passes/resolving.rs
2 participants