femtovg: Fix warning about deprecated web_sys::set_fill_style #6571
+7
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use set_fill_style_str insterad, it avoids constructing a JSValue from a str.
hunger
force-pushed
the
tobias/push-unxvprryrzup
branch
from
f964676
to
4efea99
Compare
|
I turned web-sys into a workspace dependency so we do not end up with different versions all over the place. I did not update the examples accordingly as those are supposed to stay stand-alone. |
ogoffart
approved these changes
Oct 16, 2024
| @@ -156,6 +156,8 @@ spin_on = { version = "0.1" } | |||
| strum = { version = "0.26.1", default-features = false, features = ["derive"] } | |||
| toml_edit = { version = "0.22.7" } | |||
| ttf-parser = { version = "0.21" } | |||
| # web-sys needs to be >= 0.3.72 for set_fill_style_str | |||
There was a problem hiding this comment.
we don't ususally write these kind of comments.
(otherwise we'd have one comment for each dependency)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use set_fill_style_str instead, it avoids constructing a JSValue from a str.