live-preview: Do not fail to render when top level sources are not lo… #6569
Conversation
…aded Ths can open one file in VSCode and show the preview. Then you click on another file in the file tree, which will replace the current file. This replacement invalidates the data stored in the live-previews caches, so it used to render an empty file. Read the data from disc instead -- if that is an option.
hunger
force-pushed
the
tobias/push-lorwtpxtptys
branch
from
a90e919
to
a83007a
Compare
|
is it not wrong to replace the content of the editor that we get from didOpenDocument with the content from the file? |
|
The only way we get invalidations for files open in the editor is when that editor gets closed. At that point the on-disc file becomes the one we should use. |
|
ah ok. |
|
So closing a tab in slintpad might cause problems then. |
|
It's what happens here: One file is open in the editor and something in int gets previewed. It then gets replaced by a different file. So we get an invalidation request as the original file we are previewing gets closed. That file is obviously a dependency of the current preview, so we try to rerender. That would work for any but the root file: The compiler loads data for all others from disk as needed, we just need to do that manually for the top-level file. This PR fixes that. |
|
If you close the one with the preview: Probably :-) But you can not close things in slintpad easily. |
…aded
Ths can open one file in VSCode and show the preview. Then you click on another file in the file tree, which will replace the current file.
This replacement invalidates the data stored in the live-previews caches, so it used to render an empty file. Read the data from disc instead -- if that is an option.