Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module for HTMX SSE extension #5

Merged
merged 13 commits into from
Jul 16, 2024
Merged

Module for HTMX SSE extension #5

merged 13 commits into from
Jul 16, 2024

Conversation

h0p3zZ
Copy link
Contributor

@h0p3zZ h0p3zZ commented Jul 15, 2024

  • Added SSE extension support in seperate library
  • Example code vor Vapor and Hummingbird

Copy link
Owner

@sliemeobn sliemeobn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution.

I really think the addition of a little sse-based live time view does not justify adding (and maintaining) two more example projects. Also, moving the existing examples will break existing links to them (in forum posts or similar)

Please rework the examples to keep the existing folder structure and simply add the live-time view snippets in there. It will be nice to have a little annotation on the page highlighting that the time is actually the "server time" or similar.

Sources/ElementaryHxSSE/HTMLAttribute+HxSSE.swift Outdated Show resolved Hide resolved
Sources/ElementaryHTMX/HTMLAttributeValue+HTMX.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Sources/ElementaryHxSSE/HTMLAttribute+HxSSE.swift Outdated Show resolved Hide resolved
Examples/Vapor/VaporSSEDemo/Sources/App/Routes.swift Outdated Show resolved Hide resolved
@sliemeobn sliemeobn changed the title HTMX_SSE_extension_implementation Module for HTMX SSE extension Jul 16, 2024
@h0p3zZ h0p3zZ requested a review from sliemeobn July 16, 2024 11:49
Copy link
Owner

@sliemeobn sliemeobn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

Sources/ElementaryHTMXSSE/HTMLAttribute+HTMXSSE.swift Outdated Show resolved Hide resolved
Examples/VaporDemo/Sources/App/Views.swift Outdated Show resolved Hide resolved
Examples/VaporDemo/Sources/App/Routes.swift Outdated Show resolved Hide resolved
Examples/VaporDemo/Sources/App/Views.swift Outdated Show resolved Hide resolved
Examples/HummingbirdDemo/Sources/App/Routes.swift Outdated Show resolved Hide resolved
Examples/HummingbirdDemo/Sources/App/Views.swift Outdated Show resolved Hide resolved
@h0p3zZ h0p3zZ requested a review from sliemeobn July 16, 2024 13:01
Copy link
Owner

@sliemeobn sliemeobn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tiny example fixes are needed, but I'll do them separately)

@sliemeobn sliemeobn merged commit b9f601e into sliemeobn:main Jul 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants