feat: add CLI option to allow transparent pngs #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
KermanX
approved these changes
Aug 4, 2024
antfu
approved these changes
Aug 4, 2024
|
Yeah |
KermanX
approved these changes
Aug 5, 2024
AlbertBrand
pushed a commit
to AlbertBrand/slidev
that referenced
this pull request
Aug 16, 2024
Co-authored-by: mo91dev <> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: _Kerman <kermanx@qq.com>
This was referenced Sep 6, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PNGs are generated by taking a screenshot of the page as if it were running in a browser using Playwright. Currently, PNG exports will never be transparent and will always have the default, white, browser background regardless of if the user has removed all backgrounds using css. Playwright has an
omitBackgroundproperty that can be added to the.screenshotmethod to remove this final browser background.https://playwright.dev/docs/api/class-page#page-screenshot-option-omit-background
This PR adds the
--omit-backgroundCLI option to control the visibility of the default browser background and allow for the possibility of transparent png exports. It also adds docs for this featureUsers will still need to apply additional css styling to remove the css backgrounds from their slides in order to reveal the transparency in their exports.