Boljše preverjanje datumov pri uvozu MIZŠ podatkov #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csv/schools-cases.csv.timestamp
Outdated
| 1613568164 | ||
| ======= | ||
| 1613568229 | ||
| >>>>>>> d5e22fd290f15082b09a8f100618b4fe493b8a1f |
There was a problem hiding this comment.
tole je ostanek conflict resolvinga... treba fixat
| "Start date {} is after the stop date {} in line:\n{}".format( | ||
| start_date, stop_date, row | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Could be either
logger.warning(f'Start date {start_date} is after the stop date {stop_date} in line:\n{row}')(shorter)... or ...
logger.warning('Start date %s is after the stop date %s in line:\n%s', start_date, stop_date, row)to leverage filtering using logging services where you can do aggregations for this message regardless of parameter values.
|
Also, commits can be squashed into one :) |
added 26 commits
May 23, 2021 22:28
…eč kot 1/2/3/4/5/6 mesecev. Številke so preliminarne.
…/4/5/6 mesecih, oziroma pred več kot 6 meseci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verjetno hočete izločiti popravek izdelanih csv-jev. Naj to raje naredi vaš bot.