socket-mode: prep for major release #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump minimum node version to 18 - remove unused p-* dependencies - code changes to move to new major version of ws and web-api dependencies
A Socket Mode client never receives binary payloads. You can safely assume that WS message payloads are always JSON format text data. |
seratch
approved these changes
Jan 20, 2024
…ped-for-now suite of tests for failure modes
seratch
approved these changes
Jan 24, 2024
…terface requirements. Tweak `start` behaviour to return once the client is connected rather than when authenticated (and still connecting). Binary and malformed JSON messages are raised now as DEBUG level logs. Added integration tests assuring the documented lifecycle events are raised.
filmaj
commented
Jan 24, 2024
|
Thank you so much for your patience and consistent reviews Kaz 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nycrc.jsonfile as other packages in this repo use, for holding code coverage configurationwsandweb-apidependencieswsand made the updates in here based on that. In summary, raw string buffers are passed to handler methods now (previously,wswould decode the string on your behalf automatically). Presumably to support binary payloads.