Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: require pyyaml > 3.13 to avoid an error. #2283

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Minor: require pyyaml > 3.13 to avoid an error. #2283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sky/setup_files/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ def parse_readme(readme: str) -> str:
# Cython 3.0 release breaks PyYAML installed by aws-cli.
# https://github.com/yaml/pyyaml/issues/601
# https://github.com/aws/aws-cli/issues/8036
'pyyaml<=5.3.1'
# <= 3.13 may encounter https://github.com/ultralytics/yolov5/issues/414
'pyyaml > 3.13, <= 5.3.1'
Comment on lines +119 to +120
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With yaml/pyyaml#702 merged and PyYAML 6.0.1, awscli 1.29.4 released, we might also be able to allow >=6.0.1 here. Should we test with that too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, people may not constantly upgrade their tools (aws-cli for example) to get those fixes. I think supporting latest versions can be deferred.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we discussed on call, lets defer >=6.0.1 for this PR but let's file an issue and get to it soon

]

# NOTE: Change the templates/spot-controller.yaml.j2 file if any of the
Expand Down
Loading